Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runtime): fail without retries on ConnectorInputException #3844

Merged

Conversation

ztefanie
Copy link
Contributor

Description

Set retries to zero, when ConnectorInputException is thrown.

Related issues

closes #3806

Checklist

  • PR has a milestone or the no milestone label.

@ztefanie ztefanie added this to the 8.7.0-alpha4 milestone Jan 13, 2025
@ztefanie ztefanie requested a review from a team as a code owner January 13, 2025 12:53
@ztefanie ztefanie requested a review from johnBgood January 13, 2025 12:53
@ztefanie ztefanie requested a review from johnBgood January 15, 2025 07:11
@ztefanie ztefanie force-pushed the 3806-fail-without-retries-for-connector-input-exception branch from daf4b5b to 9e97d21 Compare January 15, 2025 07:11
Copy link
Collaborator

@johnBgood johnBgood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 small comment to add the old test as well, other than that all good 💯

@johnBgood johnBgood self-assigned this Jan 15, 2025
@ztefanie ztefanie added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit 348b88d Jan 15, 2025
12 of 13 checks passed
@ztefanie ztefanie deleted the 3806-fail-without-retries-for-connector-input-exception branch January 15, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConnectorInputException should lead to a failed job without retries (technical error)
2 participants